isEOF() can throw NPE

adMartem

For example here https://github.com/adMartem/congo-parser-generator/blob/7b92fefcd2213683460222871421cd591ed3b6e9/src/templates/java/ParseException.java.ftl#L30 throws a NPE if no Tokens have been consumed and the lastConsumedToken is DUMMY_START_TOKEN.

And, tree building not enabled.
To be complete, these are the options set:

IGNORE_CASE = true;
JAVA_UNICODE_ESCAPE=false;
PARSER_PACKAGE=com.turrettech.p3cobol.compiler.parser.picture.generated;
PARSER_CLASS=PictureEncoder;
DEFAULT_LEXICAL_STATE=PICTURE;
BASE_SRC_DIR="../../../src-generated/congocc/java";
TABS_TO_SPACES=4;
PRESERVE_LINE_ENDINGS=false;
TREE_BUILDING_ENABLED=false;
MINIMAL_TOKEN=true;

adMartem

I pondered suggesting a change for this, but I'm not sure of the approach you would take. Seems like having a type for DUMMY_START_TOKEN would be a good idea, but the fact that it is really not a token makes that seem odd. But getType() is referenced in several places without a null check, so it would seem that either they all need to be guarded or some type needs to be returned.

See pull request for the patch I am using.

revusky

adMartem Seems like having a type for DUMMY_START_TOKEN would be a good idea

Ah, I see that you suggested this! This was actually the approach I decided to take.