Reaper Bug

adMartem

The Reaper appears to reap some referenced import items now. Empirically, an imported type that is referenced only as a type argument and a static import specifying a static field when only the field name is referenced, but not the Class it is in are affected. I'm pretty sure they are deleted by the Reaper, as I can change the import to a ".*" type and then all is well.

adMartem

This appears to be because the Reaper collects referenced class names by using the first Identifier in the ObjectType non-terminal, but it doesn't recurse, so it misses any annotation type references and the type arguments (parameters).

I suspect the static import of a field not being classified as referenced probably is because the reference is to the field without the class being specified, so the import is removed because the class is unreferenced (even though the field in the import is). But I haven't confirmed this conjecture.

revusky

adMartem This appears to be because the Reaper collects referenced class names by using the first Identifier in the ObjectType non-terminal, but it doesn't recurse, so it misses any annotation type references and the type arguments (parameters).

Yes, the failure to recurse was really the essence of the problem. The older way it was written was so bloody-minded that it didn't matter. It just traversed the tree (or subtree really in the case of a method declaration, say) and collected every identifier and just assumed that this was either a method call or a variable name or whatever, even identifiers that were in the wrong context. It was really very crude. Then for some reason, I decided to rewrite it to be more correct, but then the whole thing of recursing into type arguments and annotations somehow slipped my mind and none of my test suite caught that.

This should be resolved in the current version.